fixing 500 bug on empty lexical query #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaynorChavez
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
vicilliar
requested changes
May 20, 2024
RaynorChavez
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
RaynorChavez
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
RaynorChavez
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
RaynorChavez
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
RaynorChavez
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
vicilliar
requested changes
May 20, 2024
src/marqo/core/unstructured_vespa_index/unstructured_vespa_index.py
Outdated
Show resolved
Hide resolved
RaynorChavez
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
RaynorChavez
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
RaynorChavez
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
vicilliar
previously approved these changes
May 20, 2024
vicilliar
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
vicilliar
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
vicilliar
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
vicilliar
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
vicilliar
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
vicilliar
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
farshidz
requested changes
May 21, 2024
src/marqo/core/unstructured_vespa_index/unstructured_vespa_index.py
Outdated
Show resolved
Hide resolved
RaynorChavez
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
RaynorChavez
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
RaynorChavez
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
farshidz
approved these changes
May 21, 2024
farshidz
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
farshidz
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
When a user requests a lexical search with
q=""(an empty string), marqo returns a 500 error.What is the new behavior (if this is a feature change)?
The bug is due to
_lexical_searchnot creating a valid yql expression when the string is empty. We add two new conditionals in_to_vespa_lexical_queryq="" : Empty results regardless of filter ,
... where falseq="*" : Everything, apply filter if provided,
... where trueDoes this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Searching
q="*"now returns all documents.Have unit tests been run against this PR? (Has there also been any additional testing?)
Yes, added a new test
test_empty_lexical_queryRelated Python client changes (link commit/PR here)
Related documentation changes (link commit/PR here)
Other information:
Please check if the PR fulfills these requirements