Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incremental change - status labels for toggle control #236

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Incremental change - status labels for toggle control #236

wants to merge 9 commits into from
+623 −20

Conversation

smorey2
Copy link

@smorey2 smorey2 commented Oct 4, 2017

Reference: #177

stomita
stomita requested changes Dec 5, 2017
View reviewed changes
Copy link
Collaborator

@stomita stomita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The snapshot files include truly generated uuids, which prevents matching previous result.

To generate snapshots with fake uuids, run
npm run test:storyshots -- -u

@smorey2
Copy link
Author

smorey2 commented Dec 5, 2017

I merged to upstream, and noticed the commit from

"Switched to using prop-types" removed all return types in storyshots. func -> other, bool -> other.

not sure why prop-types was introduced, and allowed to break stories

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stomita stomita stomita requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smorey2 @stomita