Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profiles filter context missing #1355

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JakePaustian
Copy link
Contributor

Trys to address issue #1332

Copy link

vercel bot commented Dec 8, 2023

@JakePaustianISU is attempting to deploy a commit to the Mastodon Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@vmstan vmstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably also need to update the screenshots on this page since elements have changed.

@vmstan vmstan requested a review from a team December 8, 2023 14:59
Copy link
Sponsor Member

@andypiper andypiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but as stated in the PR, this page would benefit from updated images as well.

@andypiper andypiper self-assigned this Dec 10, 2023
@@ -35,6 +35,7 @@ Choose where the filter will be applied:
* Notifications = matching notifications will not be shown
* Public timelines = matching statuses will not appear in local/federated timelines
* Conversations = matching statuses will be hidden in threads and detailed views
* Profiles = matching profiles will be hidden
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

matching profiles will be hidden -> matching statuses will be hidden in profile views?

Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that would be a better way of phrasing it.

Copy link
Sponsor Member

@andypiper andypiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest updating the language per comments in the review.

@@ -35,6 +35,7 @@ Choose where the filter will be applied:
* Notifications = matching notifications will not be shown
* Public timelines = matching statuses will not appear in local/federated timelines
* Conversations = matching statuses will be hidden in threads and detailed views
* Profiles = matching profiles will be hidden
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that would be a better way of phrasing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants