Add more then one input placeholder in the compose view #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sahil-sahu-dev
changed the title
zeitschlag
requested changes
Jan 10, 2023
There was a problem hiding this comment.
Thank you for your work @sahil-sahu-dev 🥳 It feels like having a nice, little easter-egg in the app.
I added some comments, please have a look at them 🙂 Can you also please take care of the merge-conflicts? Thank you!
MastodonSDK/Sources/MastodonLocalization/Resources/ar.lproj/Localizable.strings
Show resolved
Hide resolved
MastodonSDK/Sources/MastodonUI/Scene/ComposeContent/View/ComposeContentView.swift
Outdated
Show resolved
Hide resolved
j-f1
reviewed
Jan 14, 2023
MastodonSDK/Sources/MastodonUI/Scene/ComposeContent/View/ComposeContentView.swift
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-> Added two placeholder texts-
1. Express what's on your mind
2. Tell us what you think
-> Changed the compose view to randomly pick one of the three placeholder strings.
-> Added string localizations for all supported languages