Refactor compose toolbar logic #908
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-f1
force-pushed
the
compose-toolbar-inline-view-logic
branch
from
739fcfa
to
b5f7183
Compare
…at do not correspond to buttons
j-f1
force-pushed
the
compose-toolbar-inline-view-logic
branch
from
b5f7183
to
0098743
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top of #907, view the clean diff at d8f7ea2e7^...739fcfa.The goal here is to remove the logic in the view model that switches over all the action button types since many of the buttons have non-basic-toggle behavior, and eliminate the use of
assertionFailureandfatalErrorby eliminating unreachable code paths.