Work around the hang due to infinite layout shifts #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #705. I have been unable to ever reproduce this hang, but based on an Instruments trace that was sent to me it appears that
contentCellFramewas changing repeatedly. Ideally we’d figure out why that is happening and get rid of it. That might require rewriting the table view in SwiftUI though (or maybe replacing the UITableView with a UIScrollView?)This change does slightly regress the UI because hitting return twice in a row causes the UI to flicker but hitting it once doesn’t. Not sure if that’s ok or not.
What would be best is if someone could get the bug to repro on their device and trace back why the layout is changing.
I don’t know if this will fix the issue.