Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Report Notes and Account Moderation Notes #30288

Merged
merged 5 commits into from
May 15, 2024
Merged

Improve Report Notes and Account Moderation Notes #30288

merged 5 commits into from
May 15, 2024

Conversation

ThisIsMissEm
Copy link
Contributor

@ThisIsMissEm ThisIsMissEm commented May 13, 2024 •
edited

This PR does a few things:

  1. Increases the maximum length allowed for the content of Report Notes and Account Moderation Notes to 2000 characters
  2. Expands test coverage to assert the maximum content length for Report Notes and Account Moderation Notes (previously we only had coverage for empty content)
  3. Improves the error handling and length constrains in views for Report Notes and Account Moderation Notes
  4. Autofocuses the notes field if the note object has errors (previously you were just dropped to the top of a rather long page)
  5. Fixes the sidebar navigation to correctly expand for errors on Account Moderation Notes and Report Notes (previously the navigation was completely collapsed in this situation)
Screenshot 2024-05-14 at 00 25 52

ClearlyClaire
ClearlyClaire requested changes May 15, 2024
View reviewed changes
Copy link
Contributor

@ClearlyClaire ClearlyClaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except for the translation thing.

config/locales/en.yml Outdated Show resolved Hide resolved
@ThisIsMissEm ThisIsMissEm force-pushed the feat/improve-report-and-account-moderation-notes branch from 243a321 to 4eaf966 Compare May 15, 2024 13:26
@ClearlyClaire ClearlyClaire added this pull request to the merge queue May 15, 2024
Merged via the queue into mastodon:main with commit 5fd5651 May 15, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClearlyClaire ClearlyClaire ClearlyClaire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ThisIsMissEm @ClearlyClaire