This repository has been archived by the owner on Jun 10, 2018. It is now read-only.
Fix Grant Code retrieval with login event handler #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code does not work in the case of brokered OIDC as it just looks for the grant code to show up as url param in one of the redirects. In the brokered OIDC scenario the broker can have a temporary code show up in the middle of the flow. e.g. if I setup a identity broker flow in Keycloak, keycloak uses a temporary code before the actual auth happens with configured OIDC IDP. In such a case, wrong code is used to request token
In this enhancement, code is retrieved only when the redirect url is corresponding to the redirect uri configured. This would work in both single IDP and brokered IDP scenario
In addition, login event handler has been added for cases where browser would have shown http basic auth popup instead of login page. This occurs in the case of brokered OIDC where Windows Integrated Authentication is triggered.