generate mode accepts -o, -fake-name-template & -q #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-royal
force-pushed
the
pr/generate-accepts-defaults
branch
from
49499c4
to
7718e31
Compare
|
Thanks for the PR @matt-royal 🙏 I will review this weekend! |
joefitzgerald
force-pushed
the
pr/generate-accepts-defaults
branch
from
e1ec564
to
608c488
Compare
When the -generate flag is given with a -o flag, that flag will be the
default value for each invocation. If the invocation specifies it's own
-o, then that value will be used. Similar logic applies for the -header
flag (which was true before this commit) and for the -q flag.
Also, there is now a -fake-name-template flag when -generate is
provided. When an invocation does not specify a -fake-name, the value in
-fake-name-template will be evaluated as a text/template string and then
run against an object with a `TargetName` field. The result will be the
-fake-name for the invocation.
For example, the following comments will result in a fake named
`TheMaskedSinger` in the `fakes` package:
//go:generate go run github.com/maxbrunsfeld/counterfeiter/v6 -generate -o fakes -fake-name-template "TheMasked{{.TargetName}}"
//counterfeiter:generate . Singer
[Issue maxbrunsfeld#191]
Authored-by: Matt Royal <mroyal@vmware.com>
Signed-off-by: Joe Fitzgerald <jfitzgerald@vmware.com>
joefitzgerald
force-pushed
the
pr/generate-accepts-defaults
branch
from
608c488
to
fe80650
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the feature discussed in #191. I did my best to add the feature without making invasive changes, but I did have to restructure how flags are parsed. I'm definitely open to feedback on how I can improve the commit or the feature itself. Here are some specific questions I have:
-fake-name-templatea good name for the flag?text/templatethe right approach here, or would a simple regex, or a prefix + suffix flag be better?text/templateworks here, isTargetNamealright as the field available in the template, or would another name be better. Perhaps justName?/cc @joefitzgerald @maxbrunsfeld