Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/mwb 472 #144

Merged
merged 16 commits into from
May 19, 2024
Merged

Feature/mwb 472 #144

merged 16 commits into from
May 19, 2024

Conversation

kaleanych
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented May 18, 2024

Codecov Report

Attention: Patch coverage is 52.90698% with 81 lines in your changes are missing coverage. Please review.

Project coverage is 50.56%. Comparing base (3c83a3d) to head (f9d52bd).
Report is 1 commits behind head on main.

Current head f9d52bd differs from pull request most recent head 6a66281

Please upload reports for the commit 6a66281 to get more accurate results.

Files Patch % Lines
...ch/backend/ontology/services/api_for_namespaces.py 0.00% 27 Missing ⚠️
...pping_workbench/backend/ontology/services/terms.py 48.14% 14 Missing ⚠️
..._workbench/backend/ontology/services/namespaces.py 50.00% 10 Missing ⚠️
...workbench/backend/mapping_package/models/entity.py 42.85% 8 Missing ⚠️
...ing_workbench/backend/ontology/models/namespace.py 89.18% 4 Missing ⚠️
...package_validator/services/sparql_cm_assertions.py 20.00% 4 Missing ⚠️
...ch/backend/conceptual_mapping_rule/services/api.py 0.00% 3 Missing ⚠️
...pping_workbench/backend/core/models/api_request.py 0.00% 3 Missing ⚠️
mapping_workbench/backend/ontology/models/term.py 86.66% 2 Missing ⚠️
...pping_workbench/backend/ontology/services/tasks.py 0.00% 2 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
+ Coverage   50.52%   50.56%   +0.04%     
==========================================
  Files         138      138              
  Lines        5168     5294     +126     
==========================================
+ Hits         2611     2677      +66     
- Misses       2557     2617      +60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@duprijil
Copy link
Collaborator

  1. discover_terms fails without error
    image
  2. Is it ok to be able to create same namespaces?
    image

@duprijil
Copy link
Collaborator

  1. discover_terms fails without error
    image

    1. Is it ok to be able to create same namespaces?
      image

Solved

@duprijil duprijil merged commit 531bd6c into main May 19, 2024
2 of 3 checks passed
@duprijil duprijil deleted the feature/MWB-472 branch May 19, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants