Fix for #62 #63

jonschlinkert · 2020-02-23T05:56:00Z

I'm leaving this PR open until I get everything fixed on micromatch and picomatch.

fixes #58

as well as a few other minor optimizations and linting.

github-actions · 2020-02-23T05:56:43Z

Coverage decreased (-0.3%) to 91.893% when pulling d64b291 on fix-issue-62 into 66e1b20 on master.

For now, we're going to skip `nyc` with the github workflow, since it gives the appearance that tests are failing when we have less than 100% coverage. I'd like to have 100%, but we're close, and that's good enough for now.

fixes #60 fixes #61

jonschlinkert added 2 commits February 23, 2020 00:52

fixes #62

2e56526

as well as a few other minor optimizations and linting.

Merge branch 'dev'

d64b291

jonschlinkert added 7 commits February 23, 2020 01:01

don't use negative lookbehind

eaab152

improve coverage, lint

5d0c254

fix tests

a49bb20

For now, we're going to skip `nyc` with the github workflow, since it gives the appearance that tests are failing when we have less than 100% coverage. I'd like to have 100%, but we're close, and that's good enough for now.

fix assert for 8.6

ad51b07

fixes #57

dbe5d92

fixes #60 fixes #61

ensure tok.output is the same as tok.value when type is text

4157b78

upgrade deps

850e970

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix for #62 #63

Fix for #62 #63

jonschlinkert commented Feb 23, 2020 •

edited

github-actions bot commented Feb 23, 2020

Fix for #62 #63

Are you sure you want to change the base?

Fix for #62 #63

Conversation

jonschlinkert commented Feb 23, 2020 • edited

github-actions bot commented Feb 23, 2020

jonschlinkert commented Feb 23, 2020 •

edited