fix: Check negative patterns before trimming #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phated
force-pushed
the
phated/trim-leading
branch
from
9bc5442
to
575de86
Compare
phated
commented
Nov 21, 2022
| @@ -31,7 +31,7 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "gulp-format-md": "^2.0.0", | |||
| "mocha": "^10.1.0" | |||
| "mocha": "^3.0.2" | |||
There was a problem hiding this comment.
This has been reverted since we didn't drop old node support in the major.
|
sorry I wasn't feeling well today. I'll take a look tomorrow morning |
|
No problem. Hope you are feeling better! If you want to fix the write permissions, I'm happy to wrap these up myself. |
|
Blocking gulpjs/glob-stream#118 |
|
cc @jonschlinkert @doowb ping |
|
@jonschlinkert @doowb Hey guys, would it be better if I just fork this and release the stuff that I need? Sorry for being a pain but it is blocking my other work. |
|
@jonschlinkert checking in here. Do you want to get these merged or should I create a new project? |
|
For people looking, the fork is available at https://github.com/gulpjs/to-absolute-glob |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to implement this in
glob-stream, I encountered a problem where my negative patterns weren't matching. I traced it to the./not being removed in negative globs.This moves the
isNegatedcheck above the trimming logic so the!will be removed from the pattern before trimming is attempted.