aiohttp: Fix type of Sec-WebSocket-Key in aiohttp_ws.py
#846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AuroraTea
force-pushed
the
patch-1
branch
2 times, most recently
from
b0d8fc9
to
8b51240
Compare
AuroraTea
changed the title
Sec-WebSocket-Key in aiohttp_ws.pySec-WebSocket-Key in aiohttp_ws.py
dpgeorge
reviewed
May 15, 2024
| @@ -143,7 +143,7 @@ async def handshake(self, uri, ssl, req): | |||
| headers["Host"] = f"{uri.hostname}:{uri.port}" | |||
| headers["Connection"] = "Upgrade" | |||
| headers["Upgrade"] = "websocket" | |||
| headers["Sec-WebSocket-Key"] = key | |||
| headers["Sec-WebSocket-Key"] = key.decode("utf-8") | |||
There was a problem hiding this comment.
Please use str(key, "utf-8"), because the decode() method is not always available.
AuroraTea
force-pushed
the
patch-1
branch
2 times, most recently
from
e16fd20
to
082b5dd
Compare
The function `binascii.b2a_base64()` returns a `bytes`, but here needs a string. Otherwise, the value of `Sec-WebSocket-Key` in the headers will be `b'<BASE64-ENCODED_RANDOM_VALUE>'`. Signed-off-by: AuroraTea <1352685369@qq.com>
|
Thanks for updating. This is now merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
binascii.b2a_base64()returns abytes.Here needs a
stringOtherwise, the value of
Sec-WebSocket-Keyin the headers will beb'<BASE64-ENCODED_RANDOM_VALUE>'.It means there will be
b'at the beginning and'at the end.