umqtt.simple: add ping_response_received for ping handling #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trescenzi
force-pushed
the
umqtt-simple-ping-response-flag
branch
from
8bd8a40
to
8322f75
Compare
Signed-off-by: Thomas Crescenzi <trescenzi@gmail.com>
trescenzi
force-pushed
the
umqtt-simple-ping-response-flag
branch
from
8322f75
to
e6bc446
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when using
pingthe response is swallowed which makes it not particularly useful. This PR adds a flagping_response_receivedto the client which is set toTrueif a response has been received inwait_msg. I've been using this approach in a personal project without any issues and it's not particularly invasive so I wanted to propose it as a solution to #332.Another possible approach is to actually respond in
wait_msgwith an actual ping response however I'm not certain how that would interact with subscriptions and those currently usingwait_msgso this approach was taken in order to not be breaking while still being useful.