Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rp2/CMakeLists.txt: Enable pins.csv usage for out-of-tree boards #14375

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mgsb
Copy link
Contributor

@mgsb mgsb commented Apr 25, 2024

The current generation of pins.h hard-codes rp2/boards as the directory for the board being built. Change this to use the value of MICROPY_BOARD_DIR to find pins.csv for both in-tree and out-of-tree boards.

The current generation of pins.h hard-codes rp2/boards as the
directory for the board being built. Change this to use the
value of MICROPY_BOARD_DIR to find pins.csv for both in-tree
and out-of-tree boards.

Signed-off-by: Mark Grosen <mark@grosen.org>
Copy link

Code size report:

   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +0 +0.000% standard
      stm32:    +0 +0.000% PYBV10
     mimxrt:    +0 +0.000% TEENSY40
        rp2:    +0 +0.000% RPI_PICO
       samd:    +0 +0.000% ADAFRUIT_ITSYBITSY_M4_EXPRESS

@Gadgetoid
Copy link
Contributor

I proposed more or less the same thing here #13766

Though I also dropped MICROPY_BOARDS_DIR since it doesn't get used often enough to warrant the extra obfuscation.

So yeah 👍 for this, all of our builds are using out of tree boards dirs and finding pins.csv fails and fails silently.

@ricksorensen
Copy link
Contributor

Addresses/closes #14342 also

@mgsb
Copy link
Contributor Author

mgsb commented Apr 25, 2024

I proposed more or less the same thing here #13766

Though I also dropped MICROPY_BOARDS_DIR since it doesn't get used often enough to warrant the extra obfuscation.

So yeah 👍 for this, all of our builds are using out of tree boards dirs and finding pins.csv fails and fails silently.

Ooops, sorry I missed yours. Maybe two PRs will help expedite merging :)

@Gadgetoid
Copy link
Contributor

Maybe two PRs will help expedite merging :)

I hope so! 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants