-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extmod: Add generic network.PPP
to work with lwIP
#14461
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
Can be enabled by a board by enabling MICROPY_PY_NETWORK_PPP_LWIP. Signed-off-by: Damien George <damien@micropython.org>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14461 +/- ##
=======================================
Coverage 98.39% 98.39%
=======================================
Files 161 161
Lines 21204 21204
=======================================
Hits 20864 20864
Misses 340 340 ☔ View full report in Codecov by Sentry. |
Code size report:
|
That PR looks good, supporting the use of e.g. LTE modems or AT-Type WiFi interfaces. |
Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
Thanks @robert-hh for the review.
Yes, thank you for that. That PR will definitely be needed! |
This PR adds a new
network.PPP
interface which works on any port that has bare-metal lwIP, eg rp2, stm32, mimxrt.It has been tested on stm32. A board needs to enable
MICROPY_PY_NETWORK_PPP_LWIP
and then it can use it as follows:Notes:
ATD*99#
), before handing over control tonetwork.PPP
.PPP.poll()
on incoming data.