Fixed a regression with reporting unused parameters in potential predicates #58514
+60
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Milestone Bug
|
@typescript-bot test it |
|
Hey @jakebailey, the results of running the DT tests are ready. Everything looks the same! |
|
@jakebailey Here they are:
tscComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
@jakebailey Here are the results of running the user tests comparing Everything looks good! |
|
@jakebailey Here are the results of running the top 400 repos comparing Everything looks good! |
sandersn
requested changes
May 17, 2024
There was a problem hiding this comment.
@danvk guessed that the source of the problem was a speculative getTypeOfSymbol. But this PR fixes resolution for all parameters. If it applies to all parameters, why wasn't this observed before Dan's change?
- Need tests of used/unused binding patterns. These probably exist already, but please double-check.
- If this implementation is correct, I think it would be easier to read in
isSelfReferenceLocation, as long as that doesn't make performance worse (from adding a second parameter).
Edit: having looked at checkIfExpressionRefinesAnyParameter, Dan's specific guess doesn't make sense to me. My (fuzzier) guess is that we haven't tried to resolve a parameter name from itself before and never observed that it mistakenly caused the parameter to be marked as used. But I'm not sure what in the new code is causing that.
src/compiler/utilities.ts
Outdated
| @@ -11360,18 +11360,23 @@ export function createNameResolver({ | |||
| location = root.parent; | |||
| } | |||
| break; | |||
| case SyntaxKind.Parameter: | |||
| case SyntaxKind.Parameter: { | |||
| const param = location as ParameterDeclaration; | |||
There was a problem hiding this comment.
style question: is there a reason for all the casts in this code? Maybe it's better to drop this alias and use location as ParameterDeclaration) everywhere.
There was a problem hiding this comment.
No specific reason, I just prefer to have a single cast than multiple ones that are the same for the same variable. I can change this if you prefer the other style.
src/compiler/utilities.ts
Outdated
| case SyntaxKind.Parameter: { | ||
| const param = location as ParameterDeclaration; | ||
| if (lastLocation === param.name) { | ||
| lastSelfReferenceLocation = param; |
There was a problem hiding this comment.
I'd almost prefer a new parameter and entry in isSelfReferenceLocation like
function isSelfReferenceLocation(node: Node, lastLocation: Node): node is SelfReferenceLocation {
switch (node.kind) {
case SyntaxKind.Parameter: return lastLocation === (node as ParameterDeclaration).name
// ...There was a problem hiding this comment.
I just pushed out the suggested change
src/compiler/utilities.ts
Outdated
| case SyntaxKind.Parameter: | ||
| case SyntaxKind.Parameter: { | ||
| const param = location as ParameterDeclaration; | ||
| if (lastLocation === param.name) { |
There was a problem hiding this comment.
what does this do when param.name is a BindingPattern? Do we have tests to make sure that they still correctly get marked unused (and used when used)?
There was a problem hiding this comment.
yeah, there are tests for that already and the changes to checkIfExpressionRefinesAnyParameter that introduced this bug don't affect binding patterns
This is correct.
It's |
Andarist
force-pushed
the
unused-locals-in-predicate
branch
from
0dcf1c2
to
3d0b2b8
Compare
jakebailey
reviewed
Jun 10, 2024
Andarist
commented
Jun 10, 2024
|
@typescript-bot test it |
|
Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your and then running There is also a playground for this build and an npm module you can use via |
|
Hey @jakebailey, the results of running the DT tests are ready. Everything looks the same! |
|
@jakebailey Here are the results of running the user tests with tsc comparing Everything looks good! |
|
@jakebailey Here they are:
tscComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
@jakebailey Here are the results of running the top 400 repos with tsc comparing Everything looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #58493