Initial Java bindings. #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Android setup has been copied from ORT but is currently untested so can be ignored for now.
Craigacp
reviewed
May 15, 2024
src/java/src/main/android/ai/onnxruntime_genai/platform/package-info.java
Outdated
Show resolved
Hide resolved
Try and improve debugging setup. Can at least run junit from the command line, but the whole java.library.path setup is still and issue.
Craigacp
reviewed
May 16, 2024
…icrosoft/onnxruntime-genai into skottmckay/InitialJavaBindings
Craigacp
approved these changes
May 20, 2024
There was a problem hiding this comment.
Looks good. I still need to make build.sh executable to get the build to run on a clean checkout, and the test generation is still locked off to Windows, but otherwise everything passes cleanly on Linux x64 when I checked it. MacOS will be fine when the environment detection is fixed.
Remove some outdated comments.
…icrosoft/onnxruntime-genai into skottmckay/InitialJavaBindings
Craigacp
reviewed
May 27, 2024
skottmckay
commented
May 29, 2024
baijumeswani
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java bindings for GenAI C API, as well as a SimpleGenAI class for simplified basic usage (text in, text out, single request with optional callback for token-by-token output).
Builds and the unit tests pass on Windows.
The Android setup has been copied from ORT but is currently untested so can be ignored for now.