Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libpsl] fix psl for static windows #38828

Closed
wants to merge 1 commit into from
Closed

[libpsl] fix psl for static windows #38828

wants to merge 1 commit into from

Conversation

talregev
Copy link
Contributor

@talregev talregev commented May 20, 2024 •
edited

[libpsl] fix psl for static windows:

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@MonicaLiu0311 MonicaLiu0311 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label May 20, 2024
@talregev talregev force-pushed the TalR/curl_fix_psl branch 3 times, most recently from 7d5528c to 2355da6 Compare May 20, 2024 11:45
dg0yt
dg0yt reviewed May 20, 2024
View reviewed changes
ports/curl/dependencies.patch Outdated Show resolved Hide resolved
ports/curl/vcpkg.json Outdated Show resolved Hide resolved
@talregev talregev mentioned this pull request May 20, 2024
Open
@talregev
Copy link
Contributor Author

Errors from the ci that I don't know how to solve:
failure logs for x64-linux.zip
failure logs for x64-windows-static.zip
failure logs for x64-windows-static-md.zip

@talregev talregev force-pushed the TalR/curl_fix_psl branch 2 times, most recently from 3ffd7ad to fdfc87d Compare May 20, 2024 17:16
@dg0yt
Copy link
Contributor

dg0yt commented May 20, 2024

For x64-windows-static, there are error logs for cmake-user. Which is a test port that provides trace info. And I find that debug curl links to some release libs:

CMake Error at CMakeLists.txt:81 (message):
  Release lib for 'Debug' build: D:/installed/x64-windows-static/lib/zstd.lib


CMake Error at CMakeLists.txt:81 (message):
  Release lib for 'Debug' build:
  D:/installed/x64-windows-static/lib/nghttp2.lib


CMake Error at CMakeLists.txt:81 (message):
  Release lib for 'Debug' build: D:/installed/x64-windows-static/lib/psl.lib


CMake Error at CMakeLists.txt:81 (message):
  Release lib for 'Debug' build:
  D:/installed/x64-windows-static/lib/icuuc.lib


CMake Error at CMakeLists.txt:81 (message):
  Release lib for 'Debug' build:
  D:/installed/x64-windows-static/lib/icudt.lib

Now we need to see which dependency is pulling in the wrong libs.

The cmake:x64-linux error is because brotli is used by curl but the link libs are in wrong order. This might be a CMake behavior when it doesn't see proper dependencies, or it might be an uncontrolled installation order dependency.

The quality of younger features in port curl seem to be less satisfying.

@talregev talregev force-pushed the TalR/curl_fix_psl branch 2 times, most recently from 38fe6b5 to 8902f83 Compare May 21, 2024 17:28
@talregev talregev changed the title [curl] fix psl feature for static windows [libpsl] fix psl for static windows May 21, 2024
@talregev talregev force-pushed the TalR/curl_fix_psl branch 2 times, most recently from 6676951 to 243a95a Compare May 21, 2024 17:36
@talregev
Copy link
Contributor Author

I can remove the test, because the test is create more problems that I don't know how to solve, that can solve in different PR.

@talregev
Copy link
Contributor Author

close in favor of #38847

@talregev talregev closed this May 21, 2024
@talregev talregev mentioned this pull request May 21, 2024
Merged
@talregev talregev deleted the TalR/curl_fix_psl branch May 21, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dg0yt dg0yt dg0yt left review comments

Assignees

@FrankXie05 FrankXie05

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[curl] with feature psl on windows static build failure
4 participants
@talregev @dg0yt @FrankXie05 @MonicaLiu0311