-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libpsl] fix psl for static windows #38828
Conversation
7d5528c
to
2355da6
Compare
Errors from the ci that I don't know how to solve: |
3ffd7ad
to
fdfc87d
Compare
For x64-windows-static, there are error logs for cmake-user. Which is a test port that provides trace info. And I find that debug curl links to some release libs:
Now we need to see which dependency is pulling in the wrong libs. The cmake:x64-linux error is because brotli is used by curl but the link libs are in wrong order. This might be a CMake behavior when it doesn't see proper dependencies, or it might be an uncontrolled installation order dependency. The quality of younger features in port curl seem to be less satisfying. |
38fe6b5
to
8902f83
Compare
6676951
to
243a95a
Compare
I can remove the test, because the test is create more problems that I don't know how to solve, that can solve in different PR. |
243a95a
to
4b730ae
Compare
close in favor of #38847 |
[libpsl] fix psl for static windows:
./vcpkg x-add-version --all
and committing the result.