issue reporter refactor (web prep) #212762
Conversation
| this.addEventListener('disableExtensions', 'click', () => { | ||
| this.issueMainService.$reloadWithExtensionsDisabled(); | ||
| }); | ||
|
|
||
| this.addEventListener('extensionBugsLink', 'click', (e: Event) => { | ||
| const url = (<HTMLElement>e.target).innerText; | ||
| windowOpenNoOpener(url); | ||
| }); |
There was a problem hiding this comment.
unsure whether any of these need a debounce. Could someone click multiple times and fire multiple times?
There was a problem hiding this comment.
also unsure, will double check with Tyler on this 😢 personally haven't seen any issues on this tho (window focus is changed in either cases)
|
Just fyi for some layering issues you might encounter: nothing can depend on |
|
@bpasero thanks for those points! atm, I'm opening via a new |
|
@justschen I think https://github.com/microsoft/vscode/wiki/Source-Code-Organization is a good read about this topic, feel free to reach out in case of questions. As for the
Again, my feeling is things would be much easier if both desktop and web would use the same issue window, opened as aux window. |
refactoring and moving around some stuff for issue reporter in preparation for web.
issue.tscontainsBaseIssueReporterService.Web issue reporter will use
browser/issue/issueReporterService.tswithIssueReporterWeb extends BaseIssueReporterServiceNormal issue reporter will use
electron-sandbox/issue/issueReporterServiceNew.tswithIssueReporterNew extends BaseIssueReporterServicein
issueMainService, we change to use the newIssueReporterNewobject.can be easily reverted simply by changing instantiation back to
IssueReporterinstead ofIssueReporterNew