Keep center frequency when changing FFT size #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miek very simple change, low impact and I have been using this for a while with no issues, would be great to merge this. |
|
its good |
|
Thanks for the review @catkira. @schneider42 is there any other feedback or is this something you can merge? |
…nter frequency Signed-off-by: Jacob Gilbert <jacob.gilbert@protonmail.com>
jacobagilbert
force-pushed
the
maintain_freq_center
branch
from
cb6bba8
to
a695572
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently the plot will jump around when changing the FFT size, especially when the FFT size is large. This maintains the relative center bin when zooming.