fix(frontend): コントロールパネルにおいて、管理者しか操作できないメニュー項目をモデレーターに表示しないように #13708
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camilla-ett
force-pushed
the
enhance_control_panel
branch
from
2cd6a77
to
b75bb11
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #13708 +/- ##
============================================
+ Coverage 64.93% 77.99% +13.06%
============================================
Files 985 185 -800
Lines 111598 25454 -86144
Branches 4437 486 -3951
============================================
- Hits 72465 19853 -52612
+ Misses 39101 5594 -33507
+ Partials 32 7 -25 ☔ View full report in Codecov by Sentry. |
syuilo
reviewed
Apr 14, 2024
| @@ -223,7 +224,8 @@ const menuDef = computed(() => [{ | |||
| to: '/admin/database', | |||
| active: currentPage.value?.route.name === 'database', | |||
| }], | |||
| }]); | |||
| // filter out when moderator operating | |||
| }].filter(menu => iAmAdmin || (iAmModerator && (menu.title !== i18n.ts.info && menu.title !== i18n.ts.settings)))); | |||
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix of #13707
Why
リンク先のissueの通りです。
コントロールパネルにおいて、管理者しか操作できないメニュー項目をモデレーターに表示しないようにします。
既に、管理者しか操作できない項目については、画面遷移先でもエラーになるようになっていますが。そもそもメニューにも出させないようにします。
Additional info (optional)
Checklist