-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(frontend): デッキUI・PageWindowでmatchAllに入ったら新しいタブで開くように #13768
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #13768 +/- ##
============================================
+ Coverage 66.36% 77.82% +11.45%
============================================
Files 990 185 -805
Lines 116839 25614 -91225
Branches 5792 487 -5305
============================================
- Hits 77546 19935 -57611
+ Misses 39262 5672 -33590
+ Partials 31 7 -24 ☔ View full report in Codecov by Sentry. |
deck uiからもそうですがウィンドウも新規タブであってほしい |
内部リンク(Misskey本体の機能であるため)には変わりないので基本的に内部で開くのでいいとおもうけど |
なのでdeckは新規タブにしてる(MkYouTubePlayer経由でiframeとかもできるけどそこまでするアレはないと判断) |
のパターンもこれで対応でしたかすみません(deckのtlから直接のみと勘違いしてました) |
👀 |
What
Why
Fix #13766
Additional info (optional)
navHook内でresolveするようになったので、2度resolveが回らないようにnavHookからresolve結果を返すこともできるようにした
Checklist