add value reader for records

[okaponta]

#546

support Record -> POJO

POJO -> Record is unimplemented, see below for details.
#546 (comment)

[yangyaofei]

Hi, I found bug here.

class Test{
    UUID userId;
}

record TestDto(UUID userId){}

Test test = modelMapper.map(new TestDto(UUID.randomUUID()), Test.class)

In this code, the test.userId is null.

[WatchdataGitHub]

这是来自QQ邮箱的假期自动回复邮件。   您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。

[yangyaofei]

I got solution.

    @Override
    public Member<Record> getMember(Record record, String memberName) {
        Field field = matchField(record, memberName);
        Class<?> type = field != null ? field.getType() : Record.class;
        return new Member<>(type) {
            @Override
            public Object get(Record source, String memberName) {
                return RecordValueReader.this.get(source, memberName);
            }
        };
    }

You use field.getClass() which is wrong, and I don't think it's necessary to return Record.class when null.

[okaponta]

@yangyaofei
Thanks for reporting and the solution. fixed in commit e7a2538

[okaponta]

CI failed, but record doesn't exist in java8, so this would not success.
We have to wait until ModelMapper supports only version upper than java14.

[chhsiao90]

There're still a lot of users using java 8, so upgrade java version is not an option. How about creating separated module?

[okaponta]

means using modelMapper.registerModule() ?

actually, I found something like that. Maybe you can use this extension...
https://github.com/modelmapper/modelmapper/blob/master/extensions/jooq/src/main/java/org/modelmapper/jooq/RecordValueReader.java

[yangyaofei]

@okaponta

ModelMapper modelMapper = new ModelMapper();
modelMapper.getConfiguration().addValueReader(new RecordValueReader());

I use your code like this. It's good.

[okaponta]

@yangyaofei
thanks, I also used it like this.

@Configuration
public class JavaConfig {

    @Bean
    public ModelMapper modelMapper() {
        ModelMapper mapper = new ModelMapper();
        mapper.getConfiguration().addValueReader(new RecordValueReader());
        return mapper;
    }
}

How about creating separated module?

actually, I'm not sure what specific actions to take based on the feedback provided.
I would appreciate it if someone could help me understand what exactly I should do.

[chhsiao90]

Thanks @okaponta for the contribution. Moved the code into separated repository https://github.com/modelmapper/modelmapper-module-record and I also had a released org.modelmapper:modelmapper-module-record:1.0.0 and it should be available soon.