chore(query-bar, crud, schema): remove query-changed, query-reset, subtab-changed events from the app COMPASS-7543 COMPASS-7544
#5814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Finally had some time to deal with the crud tests and can open this for review) This patch removes some unnecessary state and events from crud and schema plugins that we had to keep around before to be able to get the applied query value in store and to show the "outdated" banner when query was applied by a different source. Instead of using events to keep track of query bar state changes and plugin subtab change and syncing them to the reflux stores, we consolidate all "applied query" state in the query bar plugin where it belongs and expose it through a few new hooks.