chore: replace jest with mocha VSCODE-516 #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anemy
reviewed
Jan 18, 2024
| expect(postMessageSpy).to.not.be.called; | ||
|
|
||
| screen.getByText('Open form').click(); | ||
| await userEvent.click(screen.getByTestId('open-connection-form-button')); |
There was a problem hiding this comment.
Opening the connection form takes ~4 seconds for all of the animations to complete, so it's failing on default timeouts. Going to see if this is something we can fix on the connection form side. There's also an issue with focus-trap not finding the fallback node. It's likely fixed in newer versions, which we'll get with newer ConfirmationModals so I'm going to try that as well. pr: mongodb-js/compass#5362
If the delay can't go away then we can skip the animation waiting (await -> void) and just insert a quick fake delay here with a comment.
Anemy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes