Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Mongo C# Driver for enum mapping over built-in EF converters #96

Merged
merged 1 commit into from
May 23, 2024

Conversation

damieng
Copy link
Member

@damieng damieng commented May 21, 2024

The built-in converters don't handle null internally (we have a separate issue to tackle that for non-enum value converters)

This changes Enum handling to go back to our built-in conversion which will also retain better compatibility with the C# driver.

Fixes EF-128

@damieng damieng requested a review from a team as a code owner May 21, 2024 09:59
Copy link
Collaborator

@JamesKovacs JamesKovacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damieng damieng merged commit 1ab865b into mongodb:main May 23, 2024
32 of 34 checks passed
@damieng damieng deleted the ef-128 branch May 23, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants