ExtrudeGeometry: Simplify default value for ExtrudeGeometry options. #28365
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
linbingquan
force-pushed
the
dev-extrude-geometry
branch
from
7a85626
to
ad07155
Compare
| const extrudePath = options.extrudePath; | ||
|
|
||
| const uvgen = options.UVGenerator !== undefined ? options.UVGenerator : WorldUVGenerator; | ||
| const { curveSegments, steps, depth, extrudePath, UVGenerator: uvgen } = options; |
There was a problem hiding this comment.
Can you please explain the UVGenerator: uvgen pattern? What exactly does it?
There was a problem hiding this comment.
Can you please explain the
UVGenerator: uvgenpattern? What exactly does it?
doc: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Destructuring_assignment
other link: https://hacks.mozilla.org/2015/05/es6-in-depth-destructuring/
In my Chinglish to explain, most chances are that people do not understand...
These two links should explain
There was a problem hiding this comment.
I interpret it like so: Since uvgen is not directly in options, it can't be unpacked from options. So UVGenerator is unpacked and assigned to uvgen.
There was a problem hiding this comment.
This code does not use ES6 syntax, is it easy to accept?
There was a problem hiding this comment.
I still prefer the "dumb" code version yeah...
Related issue: #XXXX
Description
As the title says.