Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for setting and getting clipHighlightToContent #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mBaldasty
Copy link

PR Checklist:

  • [ x] I have tested this extensively and it does not break any existing behavior.
  • [ x] I have added/updated examples and tests for any new behavior.
  • If this is a significant change, an issue has already been created where the problem / solution was discussed: [N/A, or add link to issue here]

PR Description

Added support for getting and setting clipHighlightToContent.

Added function setClipHighlightToContent and isClipHighlightToContentEnabled (same style as as setting the clipping of data and values) in order to allow the highlight to be drawn outside of the content area without bleeding out graphs.

As the variable was already present but lacked the functions to set / get this seemed like a "missing" feature

@farfromrefug
Copy link
Member

@mBaldasty actually this is not needed as the property is public ? I have an on going heavy and breaking task to remove all those getter and setter and use properties instead. The idea is to reduce the size of the lib which is pretty big right now.

Can you confirm you can still use it without the getter and setter ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants