Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

layout that is part of a code lens should be filtered and not displayed #28794

Closed
MangoIV opened this issue May 16, 2024 · 2 comments · Fixed by #28807
Closed

layout that is part of a code lens should be filtered and not displayed #28794

MangoIV opened this issue May 16, 2024 · 2 comments · Fixed by #28807
Labels
enhancement feature request lsp

Comments

@MangoIV
Copy link
Contributor

MangoIV commented May 16, 2024

Problem

I am having issues with code lenses, in particular code lenses that would insert multiple lines when executing include the layout of the lens, i e

  • there are often multiple and different amounts of spaces
  • symbols, in particular ^@ are inserted

Steps to reproduce using "nvim -u minimal_init.lua"

Expected behavior

I expect, that if there are multiple consecutive white space tokens in code lenses, neovim replaces them with exactly one space. This matches the behaviour of e g vscode.

Thanks in advance!

Neovim version (nvim -v)

0.9.5

Language server name/version

hls 2.9.0.0

Operating system/version

nixos 24.05 pre release

Log file

No response
@MangoIV MangoIV added bug issues reporting wrong behavior lsp labels May 16, 2024
@MangoIV
Copy link
Contributor Author

MangoIV commented May 16, 2024 •
edited

IMG_3385

IMG_3386

@MangoIV
Copy link
Contributor Author

MangoIV commented May 16, 2024

In the latter screen shot you can see the warning as it is displayed by lsp_lines, as you can see the odd behaviour of the lens above matches my suspicions

@wookayin wookayin added bug issues reporting wrong behavior enhancement feature request and removed bug issues reporting wrong behavior labels May 16, 2024
MangoIV added a commit to MangoIV/neovim that referenced this issue May 17, 2024
@MangoIV
feat(lsp): hide layout in codelenses in virtual text (neovim#28794)
4e124a8 
Problem: layout i.e. whitespace that is part of codelenses is currently
displayed as weird symbols and large amounts of spaces

Solution: replace all consecutive whitespace symbols with a single space
character when trying to display codelenses as virtual text
@MangoIV MangoIV mentioned this issue May 17, 2024
Merged
MangoIV added a commit to MangoIV/neovim that referenced this issue May 17, 2024
@MangoIV
feat(lsp): hide layout in codelenses in virtual text (neovim#28794)
d4f6640 
Problem: layout i.e. whitespace that is part of codelenses is currently
displayed as weird symbols and large amounts of spaces

Solution: replace all consecutive whitespace symbols with a single space
character when trying to display codelenses as virtual text
MangoIV added a commit to MangoIV/neovim that referenced this issue May 17, 2024
@MangoIV
feat(lsp): hide layout in codelenses in virtual text (neovim#28794)
ea0a916 
Problem: layout i.e. whitespace that is part of codelenses is currently
displayed as weird symbols and large amounts of spaces

Solution: replace all consecutive whitespace symbols with a single space
character when trying to display codelenses as virtual text
mfussenegger pushed a commit that referenced this issue May 21, 2024
@MangoIV
fix(lsp): hide layout in codelenses in virtual text (#28794) (#28807)
d9a2acd 
Problem: layout i.e. whitespace that is part of codelenses is currently
displayed as weird symbols and large amounts of spaces

Solution: replace all consecutive whitespace symbols with a single space
character when trying to display codelenses as virtual text
github-actions bot pushed a commit that referenced this issue May 21, 2024
@MangoIV @github-actions
fix(lsp): hide layout in codelenses in virtual text (#28794) (#28807)
1a3b72c 
Problem: layout i.e. whitespace that is part of codelenses is currently
displayed as weird symbols and large amounts of spaces

Solution: replace all consecutive whitespace symbols with a single space
character when trying to display codelenses as virtual text

(cherry picked from commit d9a2acd)
mfussenegger pushed a commit that referenced this issue May 21, 2024
@github-actions @MangoIV
fix(lsp): hide layout in codelenses in virtual text (#28794) (#28895)
efe8a0a 
Problem: layout i.e. whitespace that is part of codelenses is currently
displayed as weird symbols and large amounts of spaces

Solution: replace all consecutive whitespace symbols with a single space
character when trying to display codelenses as virtual text

(cherry picked from commit d9a2acd)

Co-authored-by: Mango The Fourth <40720523+MangoIV@users.noreply.github.com>
huangyingw pushed a commit to huangyingw/neovim that referenced this issue May 31, 2024
@MangoIV @huangyingw
fix(lsp): hide layout in codelenses in virtual text (neovim#28794) (n…
a08e820 
…eovim#28807)

Problem: layout i.e. whitespace that is part of codelenses is currently
displayed as weird symbols and large amounts of spaces

Solution: replace all consecutive whitespace symbols with a single space
character when trying to display codelenses as virtual text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement feature request lsp
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(lsp): hide layout in codelenses in virtual text (#28794) MangoIV/neovim
2 participants
@wookayin @MangoIV