feat(lsp): hide layout in codelenses in virtual text (#28794) #28807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
justinmk
approved these changes
May 17, 2024
This comment was marked as off-topic.
This comment was marked as off-topic.
MangoIV
force-pushed
the
mangoiv/code-lenses-without-line-breaks
branch
from
4e124a8
to
d4f6640
Compare
|
force pushed to make the linter happy |
Problem: layout i.e. whitespace that is part of codelenses is currently displayed as weird symbols and large amounts of spaces Solution: replace all consecutive whitespace symbols with a single space character when trying to display codelenses as virtual text
MangoIV
force-pushed
the
mangoiv/code-lenses-without-line-breaks
branch
from
d4f6640
to
ea0a916
Compare
|
much better |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
should |
|
wrt release, this is going into |
|
Features are not backported in general, so this will be 0.11 only. (Unless it's actually a |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
thank you! |
github-actions bot
pushed a commit
that referenced
this pull request
May 21, 2024
Problem: layout i.e. whitespace that is part of codelenses is currently displayed as weird symbols and large amounts of spaces Solution: replace all consecutive whitespace symbols with a single space character when trying to display codelenses as virtual text (cherry picked from commit d9a2acd)
|
Successfully created backport PR for |
|
Git push to origin failed for release-0.10 with exitcode 1 |
|
Wow! Thank you for your work guys, this was a really cool experience to contribute, really swift and no hiccups! ❤️ |
huangyingw
pushed a commit
to huangyingw/neovim
that referenced
this pull request
May 31, 2024
…eovim#28807) Problem: layout i.e. whitespace that is part of codelenses is currently displayed as weird symbols and large amounts of spaces Solution: replace all consecutive whitespace symbols with a single space character when trying to display codelenses as virtual text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: layout i.e. whitespace that is part of codelenses is currently displayed as weird symbols and large amounts of spaces
Solution: replace all consecutive whitespace symbols with a single space character when trying to display codelenses as virtual text
This closes #28794