-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change deprecation presentation #28778
Conversation
The message can still contain specifics (like the name of the function, and possibly the file?) -- the important thing is that it is guaranteed to be a single line so it doesn't trigger the dreaded "press enter" prompt. In particular, the full stack trace should be punted to the health check (as you propose). |
To be clear: it can occupy |
e1212d5
to
a5c19ea
Compare
8617b53
to
101acb9
Compare
7b7fb80
to
c218c8f
Compare
Deprecation with vim.deprecate is currently too noisy. Show the following warning instead: [function] is deprecated. Run ":checkhealth vim.deprecated" for more information. The important part is that the full message needs to be short enough to fit in one line in order to not trigger the "Press ENTER or type command to continue" prompt. The full information and stack trace for the deprecated functions will be shown in the new healthcheck `vim.deprecated`.
Deprecation with vim.deprecate is currently too noisy. Show the
following warning instead:
[function] is deprecated. Run ":checkhealth vim.deprecated" for more information.
The important part is that the full message needs to be short enough to
fit in one line in order to not trigger the "Press ENTER or type command
to continue" prompt.
The full information and stack trace for the deprecated functions will
be shown in the new healthcheck
vim.deprecated
.