Pierremerriaux/depth nerfacto camera different resolution fix #2485
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
when I use camera with different resolutions with depth-nerfacto, it crashs in pixel_samplers.py collate_image_dataset_batch_list when we do key: value[c, y, x] for key, because value is a list. I unroll to a loop over list item and concat every at the end. not sure it is well optimize, but it works, I am able to train.