Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web-ui): rework ui #22

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

AugustinMauroy
Copy link

@AugustinMauroy AugustinMauroy commented Nov 12, 2023

WARING it's not finish I open pre to show how it's look now.

But it's need a lot of cleaning. Also I'm not expert in svelte so if I'm missing any practical bones, let me know.

@aduh95
Copy link
Contributor

aduh95 commented Nov 15, 2023

Before this change:

vite v4.4.4 building for production...
✓ 41 modules transformed.
dist/index.html                  2.06 kB │ gzip: 0.78 kB
dist/assets/index-4a129365.css   0.64 kB │ gzip: 0.27 kB
dist/assets/index-b890d69c.js   21.32 kB │ gzip: 8.41 kB
✓ built in 497ms

After this change:

vite v4.4.4 building for production...
✓ 48 modules transformed.
dist/index.html                  0.75 kB │ gzip:  0.44 kB
dist/assets/index-9d6f33c7.css  15.12 kB │ gzip:  3.02 kB
dist/assets/index-3d5ac82e.js   29.36 kB │ gzip: 10.66 kB
✓ built in 1.02s

It's a significant increase, not sure it's worth it.

@AugustinMauroy
Copy link
Author

It's a significant increase, not sure it's worth it.

I couldn't agree more. You can do it using classic CSS. But increase js is about making reusable components.

@AugustinMauroy
Copy link
Author

and what do you thinks about design ?

@aduh95
Copy link
Contributor

aduh95 commented Nov 16, 2023

and what do you thinks about design ?

I don't really have any opinion, I'm happy to not to design decisions because I feel out of my depth.

But increase js is about making reusable components.

It seems to me that we are increasing complexity for very little benefit, Caritat UI does not aim to become more than it currently is, I kinda doubt we would ever benefit from the reusability.
My preference would be to keep it as minimal a runtime as possible, so it's easier to maintain and more accessible to folks with bad internet connection.

@AugustinMauroy
Copy link
Author

I will try to simplify such à possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants