Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package: add git hook instructions #13

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Oct 27, 2016

Add instructions and a hook to call core-validate-commit from
git commits.

Depends on #11

Known issues:

  • leaves ${TMPF} around (temporary file)
  • probably will reject fixup: type commit logs
  • may be too strict if someone is just doing a simple
    'work in progress' kind of local branch

Larger improvement:

  • fold the entire hook script into a mode, and/or an alternate
    script entrypoint into core-validate-commit. This would drop
    requirements on sh, sed, grep…

Fixes: #12

Add instructions and a hook to call core-validate-commit from
git commits.

Depends on nodejs#11

Known issues:
- leaves ${TMPF} around (temporary file)
- probably will reject `fixup:` type commit logs
- may be too strict if someone is just doing a simple
'work in progress' kind of local branch

Larger improvement:
- fold the entire hook script into a mode, and/or an alternate
script entrypoint into core-validate-commit. This would drop
requirements on sh, sed, grep…

Fixes: nodejs#12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a git hook
1 participant