bin: allow file:/// urls to files containing commit messages #11
Conversation
|
Add instructions and a hook to call core-validate-commit from git commits. Depends on nodejs#11 Known issues: - leaves ${TMPF} around (temporary file) - probably will reject `fixup:` type commit logs - may be too strict if someone is just doing a simple 'work in progress' kind of local branch Larger improvement: - fold the entire hook script into a mode, and/or an alternate script entrypoint into core-validate-commit. This would drop requirements on sh, sed, grep… Fixes: nodejs#12
Add instructions and a hook to call core-validate-commit from git commits. Depends on nodejs#11 Known issues: - leaves ${TMPF} around (temporary file) - probably will reject `fixup:` type commit logs - may be too strict if someone is just doing a simple 'work in progress' kind of local branch Larger improvement: - fold the entire hook script into a mode, and/or an alternate script entrypoint into core-validate-commit. This would drop requirements on sh, sed, grep… Fixes: nodejs#12
|
Would it be possible to just allow a filepath, rather than a |
srl295
force-pushed
the
allow-file-uri
branch
from
0e79acf
to
658c478
Compare
|
@not-an-aardvark right now the implementation is that it checks whether it's a valid URL, otherwise assumes it's a sha. I think that makes sense, however, I wasn't sure what the best parameter option would be. I think a related question here is about the format of the input. right now it needs to be equivalent to The current use cases (sha, url) are the higher runner cases for command line usage. Probably this should be handled by just two additional paramteres: expecting ( |
|
It may make sense to just make the three different types of inputs (sha, url, file) require a different flag for each one. It would definitely make it less ambiguous. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
add the usage model of
core-validate-commit file:///somefile…The file needs to approximate the output of
git show --quiet --format=medium ${sha}Semver: minor