Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix coverage reporting for tests #115

Merged
merged 2 commits into from
Mar 31, 2023
Merged

chore: fix coverage reporting for tests #115

merged 2 commits into from
Mar 31, 2023

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 30, 2023

tap is not reporting coverage, probably due to the switch to ESM.

Switch to c8.

tap is not reporting coverage, probably due to the switch to ESM.

Switch to c8.
@Trott
Copy link
Member Author

Trott commented Mar 30, 2023

Ah, I see I need to generate coverage data for codecov.io and upload it. Shouldn't be a problem, but have to step away from this for a bit.

@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.76 🎉

Comparison is base (e172a82) 93.93% compared to head (4bb187a) 94.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
+ Coverage   93.93%   94.70%   +0.76%     
==========================================
  Files          19       18       -1     
  Lines         462     1302     +840     
==========================================
+ Hits          434     1233     +799     
- Misses         28       69      +41     
Impacted Files Coverage Δ
bin/cmd.js 91.92% <100.00%> (+1.22%) ⬆️
index.js 100.00% <100.00%> (ø)
lib/format-pretty.js 87.20% <100.00%> (+3.87%) ⬆️
lib/format-tap.js 58.10% <100.00%> (-8.56%) ⬇️
lib/rule.js 100.00% <100.00%> (ø)
lib/rules/co-authored-by-is-trailer.js 100.00% <100.00%> (ø)
lib/rules/fixes-url.js 94.79% <100.00%> (-1.51%) ⬇️
lib/rules/line-after-title.js 100.00% <100.00%> (ø)
lib/rules/line-length.js 100.00% <100.00%> (ø)
lib/rules/metadata-end.js 100.00% <100.00%> (ø)
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Trott
Copy link
Member Author

Trott commented Mar 31, 2023

There we go. Now it's working.

@Trott Trott merged commit 964cfdc into nodejs:main Mar 31, 2023
@Trott Trott deleted the fix branch March 31, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant