Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: dependencies = setuptools for gyp --version on Python >= 3.12 #256

Merged
merged 3 commits into from
May 26, 2024

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented May 9, 2024

Fixes #259

On Python >= 3.12

% pipx run --no-cache --spec git+https://github.com/nodejs/gyp-next.git gyp --help was erroring with

ModuleNotFoundError: No module named 'packaging'

% pipx run --no-cache --spec git+https://github.com/nodejs/gyp-next.git gyp --version is still erroring with

ModuleNotFoundError: No module named 'pkg_resources'

gyp --help was fixed in gyp-next v0.18.0
gyp --version was not

Since both modules are included setuptools let's use that recommended fix.


Proof:
% pipx install gyp-next
% gyp --version # Fails!
% pipx inject gyp-next setuptools # This is the same action as this pull request.
% gyp --version # Works as expected.
% gyp --help # Works as expected.

@cclauss cclauss requested a review from legendecas May 9, 2024 13:39
@cclauss cclauss added the python Pull requests that update Python code label May 9, 2024
@cclauss cclauss changed the title chore: dependencies = setuptools for gyp --version on Python >= 3.12 chore: dependencies = setuptools for gyp --version on Python >= 3.12 May 9, 2024
pyproject.toml Outdated Show resolved Hide resolved
@legendecas legendecas merged commit 310822c into main May 26, 2024
35 checks passed
@legendecas legendecas deleted the dependencies-=-setuptools-for-gyp---version branch May 26, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants