Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove unavailable youtube link in pull requests #52982

Merged
merged 1 commit into from
May 16, 2024
Merged

doc: remove unavailable youtube link in pull requests #52982

merged 1 commit into from
May 16, 2024

Conversation

deokjinkim
Copy link
Contributor

This video(https://www.youtube.com/watch?v=HW0RPaJqm4g) isn't available anymore. And I couldn't find a proper github code review tutorial clip yet.

@deokjinkim
doc: remove unavailable youtube link in pull requests
075f924 
This video(https://www.youtube.com/watch?v=HW0RPaJqm4g) isn't
available anymore. And I couldn't find a proper github code
review tutorial clip yet.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 14, 2024
@RedYetiDev RedYetiDev added the fast-track PRs that do not need to wait for 48 hours to land. label May 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

Fast-track has been requested by @RedYetiDev. Please 👍 to approve.

@benjamingr
Copy link
Member

Fast-Tracking, as this change doesn't (IMO) need much discussion

Speaking only for myself here - every time you take collaborator specific actions like proposing fast-tracking or approving PRs (rather than actually reviewing hard stuff etc) it creates the impression you're having a hard time understanding project boundaries which makes it harder to trust you with further responsibility.

@benjamingr
Copy link
Member

From archive.org thte video is "Code Review on GitHub" by "GitHub Training & Guides"

image

@MylesBorins as a project member who is also a GitHub employee - is the video still up somewhere or there's a blessed equivalent?

@RedYetiDev RedYetiDev removed the fast-track PRs that do not need to wait for 48 hours to land. label May 14, 2024
@RedYetiDev
Copy link
Member

Speaking only for myself here - every time you take collaborator specific actions like proposing fast-tracking or approving PRs (rather than actually reviewing hard stuff etc) it creates the impression you're having a hard time understanding project boundaries which makes it harder to trust you with further responsibility.

Understood, I'll take a step back.

benjamingr
benjamingr approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, I watched the video at https://web.archive.org/web/20170717015526/https://www.youtube.com/watch?v=HW0RPaJqm4g and it's pretty uesless tbh, I'm fine with removing until there's a better alternative

@deokjinkim deokjinkim added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels May 15, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 16, 2024
@nodejs-github-bot nodejs-github-bot merged commit 2693f09 into nodejs:main May 16, 2024
27 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 2693f09

targos pushed a commit that referenced this pull request May 21, 2024
@deokjinkim @targos
doc: remove unavailable youtube link in pull requests
63fcbcf 
This video(https://www.youtube.com/watch?v=HW0RPaJqm4g) isn't
available anymore. And I couldn't find a proper github code
review tutorial clip yet.

PR-URL: #52982
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@benjamingr benjamingr benjamingr approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@MoLow MoLow MoLow approved these changes

@Lxxyx Lxxyx Lxxyx approved these changes

@Flarna Flarna Flarna approved these changes

@RedYetiDev RedYetiDev RedYetiDev approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@deokjinkim @benjamingr @RedYetiDev @nodejs-github-bot @Trott @UlisesGascon @MoLow @Lxxyx @Flarna