feat: add as_witness builtin function in order to constrain a witness to be equal to a variable
#4641
+27
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've confirmed that this works on @zac-williamson's poseidon circuit. Happy to bikeshed on naming. |
|
I'd like to hold off on this unless @zac-williamson really needs a fix today for this. I just don't see regular users being able to debug to the point where they can identify the exact point to add |
|
Happy to hold off on this if it's not urgent, just good to have this in our back pocket. |
|
@jfecher can you approve? |
jfecher
approved these changes
May 21, 2024
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
May 21, 2024
…ic definition (noir-lang/noir#5041) feat: Implement turbofish operator (noir-lang/noir#3542) feat: add `as_witness` builtin function in order to constrain a witness to be equal to a variable (noir-lang/noir#4641) chore(experimental): Elaborate impls & non-trait impls (noir-lang/noir#5007) feat: add native rust implementation of schnorr signature verification (noir-lang/noir#5053) chore: Release Noir(0.30.0) (noir-lang/noir#4981)
TomAFrench
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
May 21, 2024
Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE fix(frontend): Call trait method with mut self from generic definition (noir-lang/noir#5041) feat: Implement turbofish operator (noir-lang/noir#3542) feat: add `as_witness` builtin function in order to constrain a witness to be equal to a variable (noir-lang/noir#4641) chore(experimental): Elaborate impls & non-trait impls (noir-lang/noir#5007) feat: add native rust implementation of schnorr signature verification (noir-lang/noir#5053) chore: Release Noir(0.30.0) (noir-lang/noir#4981) END_COMMIT_OVERRIDE --------- Co-authored-by: TomAFrench <tom@tomfren.ch>
AztecBot
added a commit
that referenced
this pull request
May 21, 2024
Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE fix(frontend): Call trait method with mut self from generic definition (#5041) feat: Implement turbofish operator (#3542) feat: add `as_witness` builtin function in order to constrain a witness to be equal to a variable (#4641) chore(experimental): Elaborate impls & non-trait impls (#5007) feat: add native rust implementation of schnorr signature verification (#5053) chore: Release Noir(0.30.0) (#4981) END_COMMIT_OVERRIDE --------- Co-authored-by: TomAFrench <tom@tomfren.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Quick fix to #4629
Summary*
This PR adds a
as_witnessfunction which takes aFieldand instructs the compiler to lay down an opcode which constrains a witness to be equal to this value.This prevents the issue in #4629 where we collect ever growing expressions which need to be broken down multiple times while reshaping the circuit. Doing this during acirgen instead allows us to avoid this repetition.
Additional Context
Documentation*
Check one:
Feature is experimental
PR Checklist*
cargo fmton default settings.