-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add recursive example #4969
base: master
Are you sure you want to change the base?
Conversation
…8bdfa1cd17ef69e' git-subtree-dir: how-to/recursive-proofs git-subtree-mainline: ae3bcde966dd2f1f52835ea83086c31f3046d812 git-subtree-split: 6ede541281290dcff86ca37d48bdfa1cd17ef69e
This reverts commit 8120d965b61323a56b16b8531cc342fb48d49cee.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. We just need to hook it up into JS workspace + tested in CI
"@noir-lang/backend_barretenberg": "^0.26.0", | ||
"@noir-lang/noir_codegen": "^0.26.0", | ||
"@noir-lang/noir_js": "^0.26.0", | ||
"@noir-lang/noir_wasm": "^0.26.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add this package to the workspace and pull these packages from there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a workspace tsconfig which this package can inherit from.
@@ -0,0 +1,23 @@ | |||
{ | |||
"license": "UNLICENSED", | |||
"scripts": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a script which generates everything necessary and then runs main.ts
? We'll then want to add this to CI.
"export:leaf": "nargo export --program-dir=./circuits/sum", | ||
"export:recurseLeaf": "nargo export --program-dir=./circuits/recurseLeaf", | ||
"export:recurseNode": "nargo export --program-dir=./circuits/recurseNode", | ||
"export:all": "yarn clean:codegen && yarn export:leaf && yarn export:recurseLeaf && yarn export:recurseNode", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we don't use noir_codegen here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Evolved from another example, and did remove use of codegen artifacts.
Assigning myself just for tracking me supporting these efforts in the Noir board. |
Also it would be good to experiment with inlining some of the text to be shown in the docs in amongst the code and using snippets to populate the doc. This would make it easier for us to keep text + code in sync. |
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/bech32@1.1.4, npm/chai-as-promised@7.1.2 |
This PR adds an example script which does recursive verification using `nargo` and the `bb` binary as based on @jzaki's javascript example noir-lang/noir#4969.
This PR adds an example script which does recursive verification using `nargo` and the `bb` binary as based on @jzaki's javascript example noir-lang/noir#4969.
This PR adds an example script which does recursive verification using `nargo` and the `bb` binary as based on @jzaki's javascript example noir-lang/noir#4969.
Description
Adds new
examples
directory with recursive example from dev-rel repo.Problem
Examples in dev-rel are not kept strictly up to date with each noir language update, so when referred to in the docs would be out of date. This code will likely need updating before automating any test as part of noir repo's CI.
Resolves #4410
Summary
There were some quirks/workarounds at the time of writing, and fixes in Noir will likely resolve those quirks (if not already).
Additional Context
A future restructure would have a new docs directory created, with the current docs moving to subfolder in that, alongside examples. So structure could be something like
docs/docs
anddocs/examples
.PS. I presume the prettier was on default cargo fmt settings.
Documentation
Check one:
PR Checklist
cargo fmt
on default settings.