support s3 directories with more than 1000 keys #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| cb(new Error("Missing CommonPrefixes from S3 Response")); | ||
| return; | ||
| } | ||
| else { |
There was a problem hiding this comment.
I don't think the else here is necessary. Once we've completed the null checks on the CommonPrefixes, Contents, and data then we'll always do the processing below.
| if (data.IsTruncated) { | ||
| params.ContinuationToken = data.NextContinuationToken; | ||
| listAllKeys(cb); | ||
| return |
There was a problem hiding this comment.
Suggested change
| return | |
| return; |
| }); | ||
|
|
||
| if (data.IsTruncated) { | ||
| params.ContinuationToken = data.NextContinuationToken; |
There was a problem hiding this comment.
Is NextContinunationToken guaranteed to be set if IsTruncated is true (seems like yes based on the docs) or do we need an additional null-check?
| else { | ||
| var contents = data.Contents; | ||
| var prefixes = data.CommonPrefixes; | ||
| contents.forEach(content => { |
There was a problem hiding this comment.
Any reason for not using map here and for prefixes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #314, where commuter only displays first 1000 keys in s3 buckets.
I'm not really familiar with javascript so apologies if the style/solution here is bad - it fixed my use case though.