Write test for utility functions #15
Conversation
lh0x00
added
@nuz/utils
|
Hi @luann112 , thanks for this PR. |
| }) | ||
|
|
||
| it('Should return a boolean value', async () => { | ||
| const result = await checkIsUrlOk('fb.com') |
There was a problem hiding this comment.
Can you mock for this effect? don't call to network!
| import compareFilesByHash from './compareFilesByHash' | ||
|
|
||
| describe('compareFilesByHash', () => { | ||
| it('Exported as default', () => { |
There was a problem hiding this comment.
Don't need this case, should you remove:
import * as func from './compareFilesByHash'| import deferedPromise from './deferedPromise' | ||
|
|
||
| describe('deferedPromise', () => { | ||
| it('Exported as default', () => { |
There was a problem hiding this comment.
Please handle (remove) as the case above
|
|
||
| describe('ensureOrigin', () => { | ||
| it('Exported as default', () => { | ||
| expect(func.default).toBeDefined() |
| }) | ||
|
|
||
| it('Should match to snapshot', () => { | ||
| expect(deferedPromise()).toMatchSnapshot() |
There was a problem hiding this comment.
Please check the prototype instead of using snapshot for this case
| }) | ||
|
|
||
| it('Should match to the snapshot', () => { | ||
| const path = require.resolve('./hashFile') |
| @@ -0,0 +1,23 @@ | |||
| import * as func from './jsonHelpers' | |||
| @@ -0,0 +1,31 @@ | |||
| import * as func from './linkedUrls' | |||
| @@ -0,0 +1,15 @@ | |||
| import * as func from './checkIsProductionMode' | |||
There was a problem hiding this comment.
Use checkIsProductionMode insead of func.
With a file export default only don't need to use:
import * as func from './checkIsProductionMode'Use below:
import checkIsProductionMode from './checkIsProductionMode'| const fileA = require.resolve('./compareFilesByHash') | ||
| const fileB = require.resolve('./deferedPromise') | ||
| expect(compareFilesByHash(fileA, fileB)).toBe(false) | ||
| }) |
There was a problem hiding this comment.
Can you update compareFilesByHash and throw an error if files received not found?
|
@luann112 I commented something, please help me update it. Don't forget to rebase with the |
No description provided.