off jsx-a11y/label-fas-for #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this rule was deprecated on eslint-plugin-jsx-a11y v6.1.0
Korilakkuma
approved these changes
Aug 29, 2018
tommy-san
reviewed
Aug 29, 2018
| some : ['nesting', 'id'] | ||
| } | ||
| }] | ||
| 'jsx-a11y/label-has-for' : 'off' // [Deprecated on eslint-plugin-jsx-a11y v6.1.0] |
There was a problem hiding this comment.
@masuP9 Do not use label-has-associated-control?
https://github.com/evcohen/eslint-plugin-jsx-a11y/releases/tag/v6.1.0
[deprecate] The rule label-has-for is deprecated and replaced with label-has-associated-control
There was a problem hiding this comment.
@tommy-san label-has-associated-control rule is already include recommend on v6.1.0
https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/src/index.js#L77
There was a problem hiding this comment.
Sorry. Contained both...
https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/src/index.js#L76-L77
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this rule was deprecated on eslint-plugin-jsx-a11y v6.1.0