Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed tabCapture example #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

vinchauhan
Copy link

With latest player.srcObject api changes

@orbitbot
Copy link
Owner

Hi, thanks for the fix. This repo is not intended to be anything else than a copy of the samples that Google have provided for chrome extensions, so updating any of them individually even if they're clearly not working isn't meaningful. The examples have not been scraped for a long time, so if you'd like to help, running/fixing the samples scraper and making a PR to update all the examples would benefit everyone.

@vinchauhan
Copy link
Author

Hi, thanks for the fix. This repo is not intended to be anything else than a copy of the samples that Google have provided for chrome extensions, so updating any of them individually even if they're clearly not working isn't meaningful. The examples have not been scraped for a long time, so if you'd like to help, running/fixing the samples scraper and making a PR to update all the examples would benefit everyone.

Sure - I will see if I can gradually fix all the apps

@orbitbot
Copy link
Owner

Sure - I will see if I can gradually fix all the apps

Please re-read what I wrote, my intent was that you might fix the scraper (which I believe has some python legacy issues with pip dependencies so it doesn't work out of the box). Once that script is running, updating all the examples in this repository is just a matter of copying over the generated files and making a commit. If you can manage to fix the script, I can easily do the rest.

@vinchauhan
Copy link
Author

Sure - I will see if I can gradually fix all the apps

Please re-read what I wrote, my intent was that you might fix the scraper (which I believe has some python legacy issues with pip dependencies so it doesn't work out of the box). Once that script is running, updating all the examples in this repository is just a matter of copying over the generated files and making a commit. If you can manage to fix the script, I can easily do the rest.

See it now since you hyperlinked - I thought the scraper was on the google examples website..but again why would they :-) . I will take a look at your scraper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants