-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON to client #5553
JSON to client #5553
Conversation
How about this work? |
@@ -1014,15 +1016,7 @@ router.post( | |||
document.collection = collection; | |||
|
|||
ctx.body = { | |||
data: | |||
apiVersion === 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically a breaking API change but it should only have been used internally in much older versions
@@ -1278,15 +1272,7 @@ router.post( | |||
}); | |||
|
|||
ctx.body = { | |||
data: | |||
apiVersion === 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically a breaking API change but it should only have been used internally in much older versions
Planning on migration to storing JSON content before continuing here as the performance implications of loading state from DB are questionable, but certainly not an improvement. |
This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 5 days |
Automatically closed due to inactivity |
Hi , I noticed that this pull request has not been updated for a while. Could you please let me know the current status? Thank you! |
See issue for what this unlocks in terms of future functionality. Makes JSON rather than markdown the canonical source of truth for reading documents.
asNavigationNode
closes #3000