Skip to content
This repository has been archived by the owner on Jan 20, 2022. It is now read-only.

fix: allow / to be used anywhere, not just a new line #414

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

iamsaumya
Copy link
Contributor

fixes #218

@iamsaumya
Copy link
Contributor Author

Hey Tom, Please review this PR whenever you get some time. I don't have much confidence in the PR because I don't understand the codebase yet.

@tommoor
Copy link
Member

tommoor commented Mar 24, 2021

This allows the menu to be triggered but the issue is more nuanced as previously it expects the current paragraph to be empty, using the same logic on a paragraph or other node that contains content will wipe it away or attempt to insert things in invalid locations.

There just needs to be some care about ensuring that the block insertion works as expected without losing any content whereever it's called from. The hovering menu itself also needs to be visually positioned next to the "/".

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow / to be used anywhere, not just a new line
2 participants