This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
Fix LinkEditor click. #540
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amazingmarvin
force-pushed
the
fix/open-link
branch
from
bd29a56
to
576d7f8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a bug where clicking the "Open link" doesn't work correctly during link creation.
Steps to reproduce bug:
onClickLinkis then called withhref="", whereas I expectedhref="example.com". Usingthis.state.valueinstead ofthis.hreffixed the issue for me. That being said I have no idea wherethis.hrefcomes from or if/when/how it's modified. Maybe this was supposed to bethis.props.hrefeverywhere? Though it would still make sense to usethis.state.valuein that case to use the updated value.