-
Notifications
You must be signed in to change notification settings - Fork 940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PolygonSeries #2033
base: develop
Are you sure you want to change the base?
Add PolygonSeries #2033
Conversation
// DataPoint cur = outline[0]; | ||
// DataPoint prev; | ||
// for (int i = 1; i < outline.Length; i++) | ||
// { | ||
// prev = cur; | ||
// cur = outline[i]; | ||
|
||
// if (cur.Equals(prev)) | ||
// { | ||
// continue; | ||
// } | ||
|
||
// var y0 = Math.Min(cur.Y, prev.Y); | ||
// var y1 = Math.Max(cur.Y, prev.Y); | ||
|
||
// if (y0 > p.Y || y1 <= p.Y) | ||
// continue; | ||
|
||
// var c = (p.Y - prev.Y) / (cur.Y - prev.Y); | ||
// var x = prev.Y + c * (cur.X - prev.Y); | ||
|
||
// if (x <= p.X) | ||
// intersectionCount++; | ||
// } | ||
|
||
// return intersectionCount % 2 == 0; | ||
//} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea where this code came from or if it works for why it's commented out. Probably don't need it at all (tracker is done in screen space).
Outstanding questions:
Outstanding problems:
|
Our rendering API does not really support this I think... So this may be hard to implement even if we found a good way to represent this. So I would think we could do without for now.
An outline tracker (that could be enabled as an option) could be nice-to-have, but I wouldn't consider it a must from the start. |
Fixes #1751 .
Checklist
-> want some interesting/compelling examples
Changes proposed in this pull request:
PolygonSeries
and examples@oxyplot/admins